London class_10- Junita Lama-JavaScript-Week-1 by Junitalama · Pull Request #483 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

Junitalama · 2023-02-18T12:54:04Z

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

Your Name:
Your City:
Your Slack Name:

Homework Details

Module:
Week:

Notes

What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?

AndriusIsin

Good job Junita! I like your way of writing code

ahmedsaif2002 · 2023-02-20T22:17:01Z

good job Junita keep going

Junitalama · 2023-02-21T11:13:13Z

Good job Junita! I like your way of writing code

thank you andrius!

Junitalama · 2023-02-21T11:13:45Z

good job Junita keep going

thank you ahmed

PaulinaWywrot

Good job Junita :)

Junitalama · 2023-02-21T19:55:00Z

Good job Junita :)

thank you dear :)

kjjwhitlock

Hi Junita, really great job! Lots of clear coding in here and you've clearly picked up the concepts well. You went the extra mile with the exercises and have really mastered string interpolation which is great to see. Watch out for typos as they can make life difficult when you're on the job :) (the amount of hours I've spent sifting through my code because of a silly typo...).

kjjwhitlock · 2023-02-22T15:37:34Z


-function convertToUSD() {}
+function convertToUSD(Pound) {
+  return Pound*1.4;


Nice! Don't forget spaces to improve readability, though :)

Nice! Don't forget spaces to improve readability, though :)

Thank you. i have added space now.

Hi Junita, really great job! Lots of clear coding in here and you've clearly picked up the concepts well. You went the extra mile with the exercises and have really mastered string interpolation which is great to see. Watch out for typos as they can make life difficult when you're on the job :) (the amount of hours I've spent sifting through my code because of a silly typo...).

THANK YOU so much for your reviews. It is really helpful for me to realise my mistakes. I will use and remember all the suggestions you have given me here in future too .

kjjwhitlock · 2023-02-22T15:39:40Z


-function convertToBRL() {}
+function convertToBRL(Pound) {
+  const BRL = 0.99 * Pound * 5.7;


Nice, but you could think about breaking this out to improve readability. Your code should read like a story, so when you are breaking out and finding the 0.99 - how can you inform collaborators that's what you're doing? e.g. add a line with an additional variable such as priceAfterFee

Nice, but you could think about breaking this out to improve readability. Your code should read like a story, so when you are breaking out and finding the 0.99 - how can you inform collaborators that's what you're doing? e.g. add a line with an additional variable such as priceAfterFee

Done!t Thank you

kjjwhitlock · 2023-02-22T15:40:19Z

+  return `Hello, my name is ${name} and I am ${age} years old`;
+}


Great use of string interpolation here!

kjjwhitlock · 2023-02-22T15:40:41Z

 function getTotal(a, b) {
-  total = a ++ b;
+  total = a + b;
+  return `The total is ${total}`;


And here too :), good job.

kjjwhitlock · 2023-02-22T15:41:23Z

-  a * b * c;
-  return;
+  return a * b * c;
 }


Spot on! Nice and clean :)

kjjwhitlock · 2023-02-22T15:52:48Z


 // Why can this code be seen as bad practice? Comment your answer.
-let badCode =
+const badCode = format((startingValue + 10)*2);


Nice, but can you do this line using all of your methods rather than maths operands here?

kjjwhitlock · 2023-02-22T15:53:28Z


 const startingValue = 2;

 // Why can this code be seen as bad practice? Comment your answer.


The task has asked you to comment here why you think this is bad code :).

I forgot to add comments. i have added now. Thank you so much for pointing it out.

kjjwhitlock · 2023-02-22T15:54:40Z

-There are some Tests in this file that will help you work out if your code is working.
+let addition = add(startingValue, 10);
+let multification = multiply(addition, 2);
+let goodCode = format(multification);


LOVE it. This is so tidy, clear and well labelled (watch out for the p in multification though).

kjjwhitlock · 2023-02-22T15:55:40Z

 function shakeBall() {
-  //Write your code in here
+  console.log("The ball has shaken!");
+  let ranomIndex = Math.floor(Math.random() * allAnswers.length);


watch out with your spelling here on randomindex :)

kjjwhitlock · 2023-02-22T15:56:05Z

+  }
+
 }



Excellent! Passes all tests and very readable, well done.

kjjwhitlock

Hi Junita, really great job! Lots of clear coding in here and you've clearly picked up the concepts well. You went the extra mile with the exercises and have really mastered string interpolation which is great to see. Watch out for typos as they can make life difficult when you're on the job :) (the amount of hours I've spent sifting through my code because of a silly typo...).

Junitalama added 4 commits February 18, 2023 12:51

done ques 1

64edfc3

Update 1-syntax-errors.js

6f3edf0

Update 1-syntax-errors.js

ef2bd95

fixed the errors

ef2c027

AndriusIsin reviewed Feb 20, 2023

View reviewed changes

PaulinaWywrot reviewed Feb 21, 2023

View reviewed changes

done extra

1780904

kjjwhitlock approved these changes Feb 22, 2023

View reviewed changes

Done changes according to review's suggestions.

6cdb7a5

		return `Hello, my name is ${name} and I am ${age} years old`;
		}


		const startingValue = 2;

		// Why can this code be seen as bad practice? Comment your answer.

Uh oh!

Conversation

Junitalama commented Feb 18, 2023

Your Details

Homework Details

Notes

Uh oh!

AndriusIsin left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedsaif2002 commented Feb 20, 2023

Uh oh!

Junitalama commented Feb 21, 2023

Uh oh!

Junitalama commented Feb 21, 2023

Uh oh!

PaulinaWywrot left a comment

Choose a reason for hiding this comment

Uh oh!

Junitalama commented Feb 21, 2023

Uh oh!

kjjwhitlock left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjjwhitlock left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants